-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor mobile search form #473
Conversation
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: 1e694e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/61012a63cc9c26000817dbe8 😎 Browse the preview: https://deploy-preview-473--wargabantuwarga.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 59.87% 59.87%
=======================================
Files 84 84
Lines 967 967
Branches 291 291
=======================================
Hits 579 579
Misses 382 382
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thanks, Mbak @ekamuktia! 🙏
Please check again @ekamuktia. The button sizes shouldn't be changed. In general, the forms have the same height as button with size Instead of redesigning the button around the form, change the |
@ekamuktia Decided to fix the form styles myself so all you need to do is revert the button styling. |
Closes #444
Description
To reduce search form space, change mobile search form styling just like desktop version
Problem found: on original styling, the primary button default size is
md
which has classtext-sm
. This styling causing the keyword input andcari
button have different height in mobile.Current Tasks
cari
button inline with keyword inputundefined
to enabletext-base sm:text-sm
styling so it won't affect other buttons and make keyword input &cari
button have same height in mobile