Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor mobile search form #473

Merged
merged 6 commits into from
Jul 28, 2021

Conversation

ekamuktia
Copy link
Collaborator

Closes #444

Description

To reduce search form space, change mobile search form styling just like desktop version

Problem found: on original styling, the primary button default size is md which has class text-sm. This styling causing the keyword input and cari button have different height in mobile.

image

Current Tasks

  • Move cari button inline with keyword input
  • Change default size of Primary Button as undefined to enable text-base sm:text-sm styling so it won't affect other buttons and make keyword input & cari button have same height in mobile
  • Show 2 filter items per row (2 column grid)
  • Update test case

@netlify
Copy link

netlify bot commented Jul 27, 2021

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: 1e694e6

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/61012a63cc9c26000817dbe8

😎 Browse the preview: https://deploy-preview-473--wargabantuwarga.netlify.app

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #473 (1e694e6) into main (bf695f4) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage   59.87%   59.87%           
=======================================
  Files          84       84           
  Lines         967      967           
  Branches      291      291           
=======================================
  Hits          579      579           
  Misses        382      382           
  Partials        6        6           
Impacted Files Coverage Δ
components/search-filter.tsx 87.09% <50.00%> (ø)
components/search-form.tsx 86.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf695f4...1e694e6. Read the comment docs.

Copy link
Member

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Thanks, Mbak @ekamuktia! 🙏

@resir014
Copy link
Member

resir014 commented Jul 27, 2021

Please check again @ekamuktia. The button sizes shouldn't be changed. In general, the forms have the same height as button with size md.

Instead of redesigning the button around the form, change the sm:text-sm class in <InputText /> into text-sm.

@resir014
Copy link
Member

@ekamuktia Decided to fix the form styles myself so all you need to do is revert the button styling.

#474

@ekamuktia ekamuktia requested a review from resir014 July 28, 2021 10:16
@resir014 resir014 merged commit efd37eb into kawalcovid19:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Mobile Search Form
3 participants