Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added donasi on hamburger menu #603

Merged
merged 7 commits into from
Aug 10, 2021

Conversation

ryanadhi
Copy link
Contributor

@ryanadhi ryanadhi commented Aug 9, 2021

Closes #599

Description

Adding menu to reach donation page (/donasi)

Current Tasks

  • Add new icon on the Homepage
  • Add new link on the Hamburger Menu
  • Add test case to assert new addition

@netlify
Copy link

netlify bot commented Aug 9, 2021

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: 7fabdee

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/611269107f3cfb00071a358b

😎 Browse the preview: https://deploy-preview-603--wargabantuwarga.netlify.app

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #603 (7fabdee) into main (80b7da0) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   80.24%   80.48%   +0.23%     
==========================================
  Files         115      115              
  Lines        1291     1291              
  Branches      420      420              
==========================================
+ Hits         1036     1039       +3     
+ Misses        249      246       -3     
  Partials        6        6              
Impacted Files Coverage Δ
lib/home/homepage-menus.tsx 100.00% <ø> (ø)
lib/layout/navigation-data.tsx 100.00% <ø> (ø)
components/ui/icons/donation-icon.tsx 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b7da0...7fabdee. Read the comment docs.

@ryanadhi
Copy link
Contributor Author

ryanadhi commented Aug 9, 2021

Hi @zainfathoni ,
following PR #604
I decided to modify the last updated test

@ryanadhi ryanadhi marked this pull request as ready for review August 9, 2021 05:26
@mazipan
Copy link
Member

mazipan commented Aug 10, 2021

Donasi page already on master.

Can we speed up this PR?

Merge branch 'main' of https://github.com/ryanadhi/wargabantuwarga.com into feat/entry-point-donation-page
@ryanadhi
Copy link
Contributor Author

@mazipan just resolved the conflict, supposed to be ready to be reviewed

Copy link
Member

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@mazipan mazipan added the automerge To be merged automatically once all the requirements are fulfilled label Aug 10, 2021
@kodiakhq kodiakhq bot merged commit 14b92a9 into kawalcovid19:main Aug 10, 2021
@mazipan
Copy link
Member

mazipan commented Aug 10, 2021

@all-contributors please add @ryanadhi for code

@allcontributors
Copy link
Contributor

@mazipan

I've put up a pull request to add @ryanadhi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge To be merged automatically once all the requirements are fulfilled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry point for Donasi Page
2 participants