feat: revert code coverage on home page #614
Conversation
- add test for home page content
- refactor testing on component/ui/alert/** - refactor testing on homepage-content
|
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: 5f679bb 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/611241a6e69b2a00083bf5d5 😎 Browse the preview: https://deploy-preview-614--wargabantuwarga.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 80.09% 80.17% +0.07%
==========================================
Files 115 115
Lines 1286 1286
Branches 418 418
==========================================
+ Hits 1030 1031 +1
+ Misses 250 249 -1
Partials 6 6
Continue to review full report at Codecov.
|
- refactor index test
resir014
added
the
automerge
There was a problem hiding this comment.
I'm reopening the #598 issue since many testing assertion issues still need to be addressed.
| <HomePage latestNews={[latestNewsItemBuilder()]} />, | ||
| ); | ||
|
|
||
| expect(container.firstChild?.hasChildNodes()).toBeTruthy(); |
There was a problem hiding this comment.
@antoooks We should use more robust assertions instead of just asserting the existence of a child node to avoid false positive test results.
FYI Mas @rubiagatra.
There was a problem hiding this comment.
ok @zainfathoni, will lookout for it on the weekend
| @@ -7,6 +7,6 @@ describe("homepage content render correctly", () => { | |||
| const { container } = render(<HomePageContent />); | |||
|
|
|||
| it("renders correctly", () => { | |||
| expect(container.firstChild).toHaveClass("flex-1"); | |||
| expect(container.hasChildNodes()).toBeTruthy(); | |||
There was a problem hiding this comment.
@antoooks We should use more robust assertions instead of just asserting the existence of a child node to avoid false positive test results.
FYI Mas @rubiagatra.
| expect(screen.getByRole("button")).toHaveClass( | ||
| `close-button text-red-400 hover:text-red-500`, | ||
| ); | ||
|
|
||
| fireEvent.click(screen.getByRole("button")); |
There was a problem hiding this comment.
@antoooks We should assert what should happen after the button is clicked.
FYI Mas @rubiagatra.
Closes #598
Description
Fixes unnecessary code coverage decrease from #604
Current Tasks