Skip to content

Commit

Permalink
fix erros when genome folder is an integer
Browse files Browse the repository at this point in the history
  • Loading branch information
Tianhao-Gu committed Jul 2, 2024
1 parent 827bf2c commit 325caaf
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 3 deletions.
5 changes: 5 additions & 0 deletions src/loaders/compute_tools/checkm2/versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,9 @@ versions:
- Remove the 'threads' and 'program_threads' parameters
and introduce the capability to specify the number of threads per tool run
- pass job_id to the tool container and remove node_id
reference_db_version: 1.0.1
- version: 0.1.5
date: 2024-06-25
notes: |
- Bug fix: tool_common.py - Converted Data IDs to string format to ensure proper comparison with associated folder names
reference_db_version: 1.0.1
6 changes: 6 additions & 0 deletions src/loaders/compute_tools/eggnog/versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,10 @@ versions:
- Remove the 'threads' and 'program_threads' parameters
and introduce the capability to specify the number of threads per tool run
- pass job_id to the tool container and remove node_id
reference_db_version: 5.0.2

- version: 0.1.3
date: 2024-06-25
notes: |
- Bug fix: tool_common.py - Converted Data IDs to string format to ensure proper comparison with associated folder names
reference_db_version: 5.0.2
5 changes: 5 additions & 0 deletions src/loaders/compute_tools/gtdb_tk/versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,9 @@ versions:
- Remove the 'threads' and 'program_threads' parameters
and introduce the capability to specify the number of threads per tool run
- pass job_id to the tool container and remove node_id
reference_db_version: release214
- version: 0.1.6
date: 2024-06-25
notes: |
- Bug fix: tool_common.py - Converted Data IDs to string format to ensure proper comparison with associated folder names
reference_db_version: release214
6 changes: 5 additions & 1 deletion src/loaders/compute_tools/mash/versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,8 @@ versions:
notes: |
- Remove the 'threads' and 'program_threads' parameters
and introduce the capability to specify the number of threads per tool run
- pass job_id to the tool container and remove node_id
- pass job_id to the tool container and remove node_id
- version: 0.1.4
date: 2024-06-25
notes: |
- Bug fix: tool_common.py - Converted Data IDs to string format to ensure proper comparison with associated folder names
6 changes: 5 additions & 1 deletion src/loaders/compute_tools/microtrait/versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,8 @@ versions:
notes: |
- Remove the 'threads' and 'program_threads' parameters
and introduce the capability to specify the number of threads per tool run
- pass job_id to the tool container and remove node_id
- pass job_id to the tool container and remove node_id
- version: 0.1.5
date: 2024-06-25
notes: |
- Bug fix: tool_common.py - Converted Data IDs to string format to ensure proper comparison with associated folder names
2 changes: 1 addition & 1 deletion src/loaders/compute_tools/tool_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def _get_data_ids(self):
with self._data_id_file:
df = pd.read_csv(self._data_id_file, sep='\t')
try:
data_ids = df[loader_common_names.DATA_ID_COLUMN_HEADER]
data_ids = df[loader_common_names.DATA_ID_COLUMN_HEADER].astype(str).tolist() # convert to string in case of int directory names

Check warning on line 214 in src/loaders/compute_tools/tool_common.py

View check run for this annotation

Codecov / codecov/patch

src/loaders/compute_tools/tool_common.py#L214

Added line #L214 was not covered by tests
except KeyError:
raise ValueError(
f"Please ensure {loader_common_names.DATA_ID_COLUMN_HEADER} column exists in the "
Expand Down

0 comments on commit 325caaf

Please sign in to comment.