Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing for workspace uploader #393

Merged
merged 14 commits into from
Aug 28, 2023
Merged

Unit testing for workspace uploader #393

merged 14 commits into from
Aug 28, 2023

Conversation

Xiangs18
Copy link
Collaborator

@Xiangs18 Xiangs18 commented Jul 28, 2023

Screen Shot 2023-08-17 at 3 49 38 PM

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.61% 🎉

Comparison is base (5958b2c) 41.35% compared to head (6389c7b) 42.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   41.35%   42.97%   +1.61%     
==========================================
  Files          68       68              
  Lines        5445     5445              
==========================================
+ Hits         2252     2340      +88     
+ Misses       3193     3105      -88     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tianhao-Gu
Tianhao-Gu previously approved these changes Aug 22, 2023
Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So usually unit tests shouldn't be accessing internal APIs [1], but given that real testing would require contacting kbase services, using real assembly files, etc. this seems reasonable for now, although not comprehensive.

When we get to the serious test writing stage we'll probably want to stand up the data services in a text fixture and run full tests, although to my mind we might want to do the database conversion first.

[1] https://blog.ploeh.dk/2015/09/22/unit-testing-internals/

@MrCreosote MrCreosote dismissed their stale review August 25, 2023 19:51

approved accidentally

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&)&_&))^^Y&%(

@Xiangs18 Xiangs18 merged commit 308403d into main Aug 28, 2023
11 checks passed
@Xiangs18 Xiangs18 deleted the dev-unit_testing branch August 28, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants