-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit testing for workspace uploader #393
Conversation
Xiangs18
commented
Jul 28, 2023
•
edited
Loading
edited
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 41.35% 42.97% +1.61%
==========================================
Files 68 68
Lines 5445 5445
==========================================
+ Hits 2252 2340 +88
+ Misses 3193 3105 -88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So usually unit tests shouldn't be accessing internal APIs [1], but given that real testing would require contacting kbase services, using real assembly files, etc. this seems reasonable for now, although not comprehensive.
When we get to the serious test writing stage we'll probably want to stand up the data services in a text fixture and run full tests, although to my mind we might want to do the database conversion first.
[1] https://blog.ploeh.dk/2015/09/22/unit-testing-internals/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&)&_&))^^Y&%(