-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RE2022-232: Add metadata per heatmap row for biolog media #418
Conversation
Could be used for things other than the media in the future
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 42.00% 42.01% +0.01%
==========================================
Files 64 64
Lines 5307 5308 +1
==========================================
+ Hits 2229 2230 +1
Misses 3078 3078
☔ View full report in Codecov by Sentry. |
This looks good to me. Though is there a more descriptive name than "media"? Or is that what we will want to display? |
That's the standard term in wetlab world afaik. We could be more specific with "growth_media" maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Could be used for things other than the media in the future