Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE2022-232: Add metadata per heatmap row for biolog media #418

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

MrCreosote
Copy link
Member

Could be used for things other than the media in the future

Could be used for things other than the media in the future
@MrCreosote
Copy link
Member Author

image
image

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (8163ad0) 42.00% compared to head (1d00bde) 42.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   42.00%   42.01%   +0.01%     
==========================================
  Files          64       64              
  Lines        5307     5308       +1     
==========================================
+ Hits         2229     2230       +1     
  Misses       3078     3078              
Files Changed Coverage Δ
src/common/product_models/heatmap_common_models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dauglyon
Copy link
Collaborator

This looks good to me. Though is there a more descriptive name than "media"? Or is that what we will want to display?

@MrCreosote
Copy link
Member Author

Though is there a more descriptive name than "media"?

That's the standard term in wetlab world afaik. We could be more specific with "growth_media" maybe?

@MrCreosote MrCreosote changed the title Add metadata per heatmap row for biolog media RE2022-232: Add metadata per heatmap row for biolog media Aug 15, 2023
Tianhao-Gu
Tianhao-Gu previously approved these changes Aug 16, 2023
Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrCreosote MrCreosote merged commit 86b1bc6 into main Aug 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants