RE2022-266: Vendor aioarango #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendor the seemingly abandonware aioarango python package so we can bump dependency versions. Removed code that we don't need (Foxx etc.) and removed a deprecated call in the ArangoClient.version() method. Next step: bump dependencies to the latest version and see what breaks.
... now that it's vendored. Things seem to work. I'd've expected catastrophic failure if httpx no longer worked with aioarango, but the spot checks I did all worked. It did require some futzing with log settings to prevent httpx from spamming the logs.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage 46.94% 46.94%
=======================================
Files 73 73
Lines 6299 6301 +2
=======================================
+ Hits 2957 2958 +1
- Misses 3342 3343 +1 ☔ View full report in Codecov by Sentry. |
MrCreosote
requested review from
Tianhao-Gu
and removed request for
Xiangs18
Tianhao-Gu
approved these changes
Nov 16, 2023
|
@Tianhao-Gu it's not exactly copy and paste. I cut out some code (and the imports for that code) that we don't need and changed the |
|
Also I added a readme you should check |
👍 I am ok with the overall PR and the version method changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits here:
Closes #163