Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE2022-334: add docs re adding new collections #696

Merged
merged 21 commits into from
Apr 10, 2024
Merged

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.21%. Comparing base (5016106) to head (c121701).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #696   +/-   ##
========================================
  Coverage    46.21%   46.21%           
========================================
  Files           78       78           
  Lines         7028     7028           
========================================
  Hits          3248     3248           
  Misses        3780     3780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCreosote
Copy link
Member

I think what Shane was talking here was a step by step guide though the entire process, starting from loading data into the workspace through activating the collection

@Tianhao-Gu
Copy link
Collaborator Author

I think what Shane was talking here was a step by step guide though the entire process, starting from loading data into the workspace through activating the collection

We already have docs re loading data.

@MrCreosote
Copy link
Member

Then those could either be linked to, if it'd be clear to someone going through this process for the first time, or incorporated here

@Tianhao-Gu
Copy link
Collaborator Author

Then those could either be linked to, if it'd be clear to someone going through this process for the first time, or incorporated here

👍

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is def more along the lines of what @scanon was looking for I think but here are still a number of gotchas for new users

docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, about done

docs/genome_to_collection.md Outdated Show resolved Hide resolved
docs/genome_to_collection.md Outdated Show resolved Hide resolved
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tianhao-Gu Tianhao-Gu merged commit ae9b003 into develop Apr 10, 2024
11 checks passed
@Tianhao-Gu Tianhao-Gu deleted the dev_doc_overhaul branch April 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants