Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RE2022-336: remove threads from tool execution #709

Merged
merged 5 commits into from
Apr 4, 2024
Merged

RE2022-336: remove threads from tool execution #709

merged 5 commits into from
Apr 4, 2024

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.11111% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 46.25%. Comparing base (01c92e8) to head (7bf911a).

Files Patch % Lines
src/loaders/compute_tools/tool_common.py 11.11% 24 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #709      +/-   ##
===========================================
+ Coverage    46.14%   46.25%   +0.11%     
===========================================
  Files           78       78              
  Lines         7034     7015      -19     
===========================================
- Hits          3246     3245       -1     
+ Misses        3788     3770      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MrCreosote
MrCreosote reviewed Apr 4, 2024
View reviewed changes
MrCreosote
MrCreosote approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tianhao-Gu Tianhao-Gu merged commit da3d2b1 into develop Apr 4, 2024
10 of 11 checks passed
@Tianhao-Gu Tianhao-Gu deleted the dev_taskfarmer_gen branch April 4, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCreosote MrCreosote MrCreosote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tianhao-Gu @MrCreosote