Fail lint when a single translation file has more than one string wit…

…h the same key.

This isn't going to catch all duplicates. Duplicates also can still exist between files, and with mismatch cases. That's OK, one thing at a time.

package.json

@@ -76,9 +76,10 @@
     "build:server": "tsc --build src/tsconfig.json",
     "build:tests": "tsc --build tests/tsconfig.json",
     "clean": "rm -r ./build/ ./src/genfiles/ || true",
-    "lint": "npm run lint:server && npm run lint:client",
+    "lint": "npm run lint:server && npm run lint:i18n && npm run lint:client",
     "lint:client": "vti diagnostics",
     "lint:server": "eslint --cache src tests --ext ts --ext vue",
+    "lint:i18n": "npx ts-node src/tools/translation_audit.ts",
     "lint:fix": "eslint --fix src tests --ext ts --ext vue",
     "make:cards": "node build/src/server/tools/export_card_rendering.js",
     "make:css": "lessc src/styles/common.less build/styles.css && node src/server/tools/gzip.js",

src/tools/translation_audit.ts

@@ -52,6 +52,7 @@ function parseJson(input: string): MultiMap<string, string> {
 
 const pathToTranslationsDir = path.resolve('src/locales');
 
+let errors = 0;
 const dirs = fs.readdirSync(pathToTranslationsDir);
 for (const lang of dirs) {
   const localeDir = path.join(pathToTranslationsDir, lang);
@@ -69,10 +70,15 @@ for (const lang of dirs) {
       for (const key of results.keys()) {
         if (results.get(key)!.length > 1) { // eslint-disable-line @typescript-eslint/no-non-null-assertion
           const uniqueCount = new Set(results.get(key)).size;
-          console.log(filename, key, uniqueCount);
+          console.log(filename, '[', uniqueCount, '] [', key, ']');
+          errors++;
         }
       }
     }
   }
 }
 
+if (errors > 0) {
+  console.error('Multiple translation strings in the same file. Stopping.');
+  process.exit(1);
+}