This repository has been archived by the owner on Nov 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Style guide #67
Draft
kbgg
wants to merge
2
commits into
dev
Choose a base branch
from
style-guide
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Style guide #67
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
# Contribution Guidelines | ||
|
||
Before opening any issues or proposing any pull requests, please read | ||
this document in its entirety. | ||
|
||
## Questions | ||
|
||
The GitHub issue tracker is for *bug reports* and *feature requests*. Please do | ||
not use it to ask questions about how to use this plugin. For questions about | ||
usage refer to the documentation. If your question is not answered in the | ||
documentation, join the [gitter](https://gitter.im/qgis-stac-browser/community) | ||
and ask your questions there. | ||
|
||
## Good Bug Reports | ||
|
||
Please be aware of the following things when filing bug reports: | ||
|
||
1. Avoid raising duplicate issues. *Please* use the GitHub issue search feature | ||
to check whether your bug report or feature request has been mentioned in | ||
the past. Duplicate bug reports and feature requests are a huge maintenance | ||
burden on the limited resources of the project. If it is clear from your | ||
report that you would have struggled to find the original, that's ok, but | ||
if searching for a selection of words in your issue title would have found | ||
the duplicate then the issue will likely be closed extremely abruptly. | ||
2. When filing bug reports about exceptions or tracebacks, please include the | ||
*complete* traceback. Partial tracebacks, or just the exception text, are | ||
not helpful. | ||
3. Make sure you provide a suitable amount of information to work with. This | ||
means you should provide: | ||
|
||
- Guidance on **how to reproduce the issue**. Ideally, this should be a | ||
list of steps that can be taken to reproduce the issue. | ||
Failing that, let us know what you're doing, how often it happens, what | ||
environment you're using, etc. Be thorough: it prevents us needing to ask | ||
further questions. | ||
- Tell us **what you expected to happen**. When we follow your steps, | ||
what are we expecting to happen? What does "success" look like for your | ||
process? | ||
- Tell us **what actually happens**. It's not helpful for you to say "it | ||
doesn't work" or "it fails". Tell us *how* it fails: do you get an | ||
exception? A hang? A non-200 status code? How was the actual result | ||
different from your expected result? | ||
- Tell us **what version of QGIS STAC Browser you're using**, and | ||
**how you installed it**. Different versions of QGIS STAC Browser behave | ||
differently and have different bugs. | ||
|
||
If you do not provide all of these things, it will take us much longer to | ||
fix your problem. If we ask you to clarify these and you never respond, we | ||
will close your issue without fixing it. | ||
|
||
## Pull Requests | ||
|
||
Good pull requests should follow these guidelines: | ||
|
||
1. Make your pull request merge into the `dev` branch. The `master` branch | ||
is reserved for the current stable release while the `dev` branch is the | ||
working branch. | ||
|
||
2. Follow the [PEP 8](https://www.python.org/dev/peps/pep-0008) style guide. | ||
There are a few exceptions to this style guide which are allowed: | ||
|
||
- Lines should be a maximum of 79 characters long. | ||
- Lines can be 99 characters long when inconvieniet. | ||
- Lines can be a maximum of 119 characters long in extreme cases. | ||
- Qt widget names should be in camel case to follow Qt convention. | ||
- Qt widget names should end in the type of widget (i.e. cancelButton, dateLabel). | ||
- Classes which interact with QGIS/Qt should use camelCase for their property, method and variable names. | ||
- Event callbacks should be marked private. | ||
|
||
3. Implement type hints for all functions/methods ([PEP 484](https://www.python.org/dev/peps/pep-0484/)) | ||
|
||
4. Make sure your code passes all linting and test requirements before submitting your pull request. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -13,6 +13,10 @@ Whenever dev stabilizes a release is cut and we merge dev in to master. So maste | |||||
It is possible that there may be small releases in quick succession, especially if they are nice improvements that do | ||||||
not require lots of updating. | ||||||
|
||||||
## Contributing | ||||||
|
||||||
Please read the [contributing guide](CONTRIBUTING.md) before submitting any pull requests. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
## Building | ||||||
|
||||||
To build the plugin and deploy to your plugin directory you will need the [pb_tool](http://g-sherman.github.io/plugin_build_tool/) CLI tool. | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.