This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Asset search and i18n fixes #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking the "Search" button was POSTing to edit_admin_asset_path, which is not the desired behavior. Instead, the "Search" button now performs the search in the same manner as the observe_field action.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assets search form was POSTing to
edit_admin_asset_pathwhen the Search button was pressed or the user hit Enter in the form, which wasn't the expected behavior. I changed the form to perform the same action as theobserve_fieldaction. (Note: I also made this change in the 0.8 branch, which is where I first encountered the problem.)There's also 2 commits to the rake tasks from 2 months ago related to the i18n work that I apparently forgot to send you a pull request for.