Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set cmake_minimum_required version to 3.26 #1099

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set cmake_minimum_required version to 3.26 #1099

wants to merge 1 commit into from
+1 −1

Conversation

2bt
Copy link

@2bt 2bt commented Jan 23, 2025

Generator expression BUILD_LOCAL_INTERFACE requires cmake minimum version 3.26

@2bt
set cmake_minimum_required version to 3.26
0a5c40f 
Generator expression BUILD_LOCAL_INTERFACE requires cmake minimum version 3.26
@kcat
Copy link
Owner

kcat commented Jan 23, 2025

BUILD_LOCAL_INTERFACE is only used for static builds, which isn't a common build setup and isn't required for the normal dynamic build. Would be better to set the required version to what's necessary for the common/default build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2bt @kcat