-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JokerDisplay Compatibility #1
base: master
Are you sure you want to change the base?
Conversation
Pushed an update for As it is now, let's say you played To me this just feels like an odd disconnect between the information given in the two locations. A more elegant solution is needed before I feel comfortable saying this PR is ready to be merged but I wanted to get something working at least. |
93% completed
see comment in code not sure what is wrong
for readability and parity with JokerDisplay tooltip no functionality changes and can be cherrypicked if undesired
f2e2c75
to
51e5a18
Compare
Another attempt. (After rebasing on top of This time the tooltip shows the overall effect on the current hand. However, there does seem to be a bug with this new version. Whenever using a consumable, the tooltip resets back to |
This PR includes https://github.com/nh6574/JokerDisplay tooltips for all KCVanilla Jokers
except forPower Grid
.I don't understand whatPower Grid
does... I assume it should be starting atx1.0
and gainingx0.2
for every playing card scored with +Mult, then resetting on round end. Testing in game, however, I can't get it to increase (or decrease) fromx1.2
... It even starts the round atx1.2
! And while claimingx1.2
, it doesn't seem to ever actually apply thatx0.2
mult anywhere. Played hands just skip over this Joker. I've tried+Mult
,xMult
,Holographic
,Polychrome
,Lucky
, andRed Seal
. Nothing changes. Your code looks fine, so I don't understand.Testing was done with:
I wasn't even includingJokerDisplay
compat in testing, just this mod and the Joker's core functionality.*shrugs* I'm leaving it with no display for now. I don't want to add something that I cannot test for.I assume just a simplex_mult
border_node is all that is needed. (Can be copied directly from Handy.)Please discuss within this PR (or Discord) and I will update it, or you may merge this and do so yourself.Also included is a change to the description of
Luck of the Irish
as a separate commitf2fe505
to be cherrypicked if undesired. This change puts the description in parity with the visuals of the new tooltip and improves its readability IMO