chore: enhance metadata fetch perf (#930)

Signed-off-by: peefy <[email protected]>
kcl-lang · Nov 29, 2023 · 714622b · 714622b
1 parent 1d7ae69
commit 714622b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/kclvm/driver/src/kpm_metadata.rs b/kclvm/driver/src/kpm_metadata.rs
@@ -58,7 +58,11 @@ impl Metadata {
 /// [`fetch_metadata`] returns the KCL module metadata.
 #[inline]
 pub fn fetch_metadata(manifest_path: PathBuf) -> Result<Metadata> {
-    fetch_mod_metadata(manifest_path.clone()).or(fetch_kpm_metadata(manifest_path))
+    use std::result::Result::Ok;
+    match fetch_mod_metadata(manifest_path.clone()) {
+        Ok(result) => Ok(result),
+        Err(_) => fetch_kpm_metadata(manifest_path),
+    }
 }
 
 /// [`fetch_kpm_metadata`] will call `kpm metadata` to obtain the metadata.

diff --git a/kclvm/tools/src/LSP/src/completion.rs b/kclvm/tools/src/LSP/src/completion.rs
@@ -397,12 +397,12 @@ fn completion_import_builtin_pkg(program: &Program, pos: &KCLPos) -> IndexSet<KC
 
 /// Complete schema name
 ///
-/// ```no_run
+/// ```no_check
 /// #[cfg(not(test))]
 /// p = P<cursor>
 /// ```
 /// complete to
-/// ```no_run
+/// ```no_check
 /// #[cfg(not(test))]
 /// p = Person(param1, param2){}<cursor>
 /// ```

diff --git a/kclvm/tools/src/LSP/src/test_data/hover_test/kcl.mod b/kclvm/tools/src/LSP/src/test_data/hover_test/kcl.mod