Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to helm/[email protected] and skip releasing for existing versions #63

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

embik
Copy link
Member

@embik embik commented Sep 20, 2023

This bumps the helm/chart-releaser-action to the latest available version (v1.6.0) and also enables skip_existing, an option that will prevent our GitHub Actions to fail on every commit we merge into main that doesn't bump the chart version.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@embik
Copy link
Member Author

embik commented Sep 20, 2023

/cc @xrstf @mjudeikis

@embik
Copy link
Member Author

embik commented Sep 20, 2023

/hold

I think I made a mistake and the configuration parameter is not available in v1.5.0.

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@embik embik marked this pull request as draft September 20, 2023 10:17
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@embik
Copy link
Member Author

embik commented Oct 26, 2023

xref helm/chart-releaser-action#152

@embik embik force-pushed the github-action-update branch from 8105ac5 to 8c24944 Compare January 5, 2024 08:40
@embik embik changed the title Update to helm/[email protected] and skip releasing for existing versions Update to helm/[email protected] and skip releasing for existing versions Jan 5, 2024
@embik embik marked this pull request as ready for review January 5, 2024 08:40
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2024
@embik
Copy link
Member Author

embik commented Jan 5, 2024

1.6.0 of the github action was released in November, so now we can upgrade and set this.

@embik
Copy link
Member Author

embik commented Jan 5, 2024

/hold cancel

ping @xrstf @mjudeikis

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7c4289dcab90477f897675a3a2337ee983434a29

@embik
Copy link
Member Author

embik commented Jan 5, 2024

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@kcp-ci-bot kcp-ci-bot merged commit 23287d7 into kcp-dev:main Jan 5, 2024
@embik embik deleted the github-action-update branch January 5, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants