weak

kean · Aug 8, 2024 · bb489fe · bb489fe
1 parent e97d20a
commit bb489fe
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/Sources/Nuke/Tasks/TaskFetchOriginalData.swift b/Sources/Nuke/Tasks/TaskFetchOriginalData.swift
@@ -54,7 +54,8 @@ final class TaskFetchOriginalData: AsyncPipelineTask<(Data, URLResponse?)> {
                 guard let self else {
                     return finish()
                 }
-                self.pipeline.queue.async {
+                self.pipeline.queue.async { [weak self] in
+                    guard let self else { return }
                     self.loadData(urlRequest: urlRequest, finish: finish)
                 }
             }
@@ -83,14 +84,16 @@ final class TaskFetchOriginalData: AsyncPipelineTask<(Data, URLResponse?)> {
         let dataLoader = pipeline.delegate.dataLoader(for: request, pipeline: pipeline)
         let dataTask = dataLoader.loadData(with: urlRequest, didReceiveData: { [weak self] data, response in
             guard let self else { return }
-            self.pipeline.queue.async {
+            self.pipeline.queue.async { [weak self] in
+                guard let self else { return }
                 self.dataTask(didReceiveData: data, response: response)
             }
         }, completion: { [weak self] error in
             finish() // Finish the operation!
             guard let self else { return }
             signpost(self, "LoadImageData", .end, "Finished with size \(Formatter.bytes(self.data.count))")
-            self.pipeline.queue.async {
+            self.pipeline.queue.async { [weak self] in
+                guard let self else { return }
                 self.dataTaskDidFinish(error: error)
             }
         })

diff --git a/Sources/Nuke/Tasks/TaskFetchWithPublisher.swift b/Sources/Nuke/Tasks/TaskFetchWithPublisher.swift
@@ -19,7 +19,8 @@ final class TaskFetchWithPublisher: AsyncPipelineTask<(Data, URLResponse?)> {
                 guard let self else {
                     return finish()
                 }
-                self.pipeline.queue.async {
+                self.pipeline.queue.async { [weak self] in
+                    guard let self else { return }
                     self.loadData { finish() }
                 }
             }
@@ -40,12 +41,14 @@ final class TaskFetchWithPublisher: AsyncPipelineTask<(Data, URLResponse?)> {
         let cancellable = publisher.sink(receiveCompletion: { [weak self] result in
             finish() // Finish the operation!
             guard let self else { return }
-            self.pipeline.queue.async {
+            self.pipeline.queue.async { [weak self] in
+                guard let self else { return }
                 self.dataTaskDidFinish(result)
             }
         }, receiveValue: { [weak self] data in
             guard let self else { return }
-            self.pipeline.queue.async {
+            self.pipeline.queue.async { [weak self] in
+                guard let self else { return }
                 self.data.append(data)
             }
         })