Remove Sendable conformance from AsyncPipelineTask

kean · Aug 18, 2024 · cd82f34 · cd82f34
1 parent 97c3ccd
commit cd82f34
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/Sources/Nuke/Tasks/AsyncPipelineTask.swift b/Sources/Nuke/Tasks/AsyncPipelineTask.swift
@@ -6,7 +6,7 @@ import Foundation
 
 // Each task holds a strong reference to the pipeline. This is by design. The
 // user does not need to hold a strong reference to the pipeline.
-class AsyncPipelineTask<Value: Sendable>: AsyncTask<Value, ImagePipeline.Error>, @unchecked Sendable {
+class AsyncPipelineTask<Value: Sendable>: AsyncTask<Value, ImagePipeline.Error> {
     let pipeline: ImagePipeline
     // A canonical request representing the unit work performed by the task.
     let request: ImageRequest

diff --git a/Sources/Nuke/Tasks/AsyncTask.swift b/Sources/Nuke/Tasks/AsyncTask.swift
@@ -16,7 +16,6 @@ import Foundation
 ///
 @ImagePipelineActor
 class AsyncTask<Value: Sendable, Error: Sendable>: AsyncTaskSubscriptionDelegate {
-
     private struct Subscription {
         let closure: (Event) -> Void
         weak var subscriber: AnyObject?

diff --git a/Sources/Nuke/Tasks/TaskFetchWithClosure.swift b/Sources/Nuke/Tasks/TaskFetchWithClosure.swift
@@ -4,8 +4,6 @@
 
 import Foundation
 
-// TODO: (nuke13) stop inhereting from AsyncPipelineTask
-
 /// Fetches data using the publisher provided with the request.
 /// Unlike `TaskFetchOriginalImageData`, there is no resumable data involved.
 final class TaskFetchWithClosure: AsyncPipelineTask<(Data, URLResponse?)> {
@@ -28,8 +26,6 @@ final class TaskFetchWithClosure: AsyncPipelineTask<(Data, URLResponse?)> {
         }
     }
 
-    // TODO: (nuke13) implement in TaskFetchOriginalData using the same protocol
-
     // This methods gets called inside data loading operation (Operation).
     private func loadData(finish: @escaping () -> Void) {
         guard !isDisposed else {