Added the onStart callback to SwiftUI.LazyImage #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
reviewed
Nov 17, 2023
Sources/NukeUI/FetchImage.swift
Outdated
| @@ -184,6 +188,10 @@ public final class FetchImage: ObservableObject, Identifiable { | |||
| handle(result: .failure(error)) | |||
| } | |||
| } | |||
|
|
|||
| if let task = imageTask { | |||
There was a problem hiding this comment.
The task is always going to be empty at this point, to it's not going to get called. I'm not entire sure why I added this load() variant in the first place, to be honest, but I think it would be acceptable to not call onStart here.
There was a problem hiding this comment.
Yup, I agree, I wasn't sure if you had something planned so I added it just in case. I'll remove it
|
Hey, thanks for fixing the typos as well, @urbaneewe; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.