Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visionOS support #239

Merged
merged 1 commit into from
Apr 13, 2024
Merged

visionOS support #239

merged 1 commit into from
Apr 13, 2024

Conversation

maximality
Copy link
Contributor

@maximality maximality commented Feb 18, 2024

The current version of the Pulse library does not support the visionOS target, resulting in Xcode generating an error when attempting to build our project with a Pulse dependency for visionOS.

I've decided to fix it. Tested the demo app – works and looks good!

Simulator Screenshot - Apple Vision Pro - 2024-02-18 at 17 11 43

@kean
Copy link
Owner

kean commented Feb 18, 2024

Awesome work, @maximality. You got much further than I did when I tried to get it to work on visionOS.

I think we could get this merged in this state and get more folks to contribute and iterate on it. There are some issues with the way the current components work on visionOS. For example, if definitely needs a wider log list, reworked controls, and an improved response body viewer. Unfortunately, I'm not an expert on the visionOS design, so I don't what the solution will be. Maybe it could take more cues from the tvOS components in Pulse.

What are your plans for this PR in particular and visionOS support in general? Would you like to continue pushing it forward?

Btw, I've been in the museum from your profile photo 👋

@maximality
Copy link
Contributor Author

maximality commented Feb 18, 2024

Hey, @kean!

What are your plans for this PR in particular and visionOS support in general? Would you like to continue pushing it forward?

Well, for now I just use it as in this PR in my project and it does it's job.
But I totally agree that we could do a better UI for visionOS. I will try to find some time to think on how we can improve it (not a visionOS expert, but hopefully on my way to). Open to any suggestions from community.

Btw, I've been in the museum from your profile photo 👋

Haha, awesome, small world!

@Mcrich23
Copy link
Contributor

I think it looks pretty good! only thing I see can be an issue is the blue text in the top left

@kean
Copy link
Owner

kean commented Apr 13, 2024

I reviewed the changes and it seems to be good to merge. Thanks for investing your time in this PR, @maximality. It was quite a lot of work, and I appreciate it. If you'd like to continue working on it, your contributions are welcome, and I'll try to provide fast code reviews.

@kean kean merged commit 993f6db into kean:main Apr 13, 2024
8 of 10 checks passed
@kean
Copy link
Owner

kean commented Apr 13, 2024

There was a merge conflict, so I created a separate PR with a fix, and it is now merged #249.

@maximality
Copy link
Contributor Author

Thanks @kean !

@kean kean mentioned this pull request May 7, 2024
@Vaberer
Copy link

Vaberer commented Jun 18, 2024

Are there plans to merge VisionOS support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants