Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to use InMemory CoreData for logs #247

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Added option to use InMemory CoreData for logs #247

merged 1 commit into from
Apr 13, 2024

Conversation

z-turk3
Copy link
Contributor

@z-turk3 z-turk3 commented Mar 26, 2024

• Adds LoggerStore Option to opt-out of the persistent on device storage of the SQL lite database
• Can be used in cases where for security reasons user logs must not be stored on the device as they can contain sensitive data like the request token
• Adds test to confirm in memory configuration

@z-turk3
Copy link
Contributor Author

z-turk3 commented Mar 26, 2024

Hey @kean, I have a specific use case where I can not store the logs on the device data because the client considers this as a security vulnerability. In order to mitigate this, I added the option to use Core Data in memory storage type which won't create the sql lite file on the device.

I hope this change works for you or if you have a different approach for my issue I'm all ears 🙂

@kean
Copy link
Owner

kean commented Apr 13, 2024

Nice addition, thank you!

@kean kean merged commit ef3f9ae into kean:main Apr 13, 2024
10 checks passed
@z-turk3 z-turk3 deleted the feature/in-memory-logs branch April 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants