feat: support disabling docker legacy service links creation in keda …

…containers (#725) * Disable docker legacy service links Signed-off-by: Gabi Davar <[email protected]> * switch default to true Signed-off-by: Gabi Davar <[email protected]> --------- Signed-off-by: Gabi Davar <[email protected]>
kedacore · Jan 26, 2025 · 4092615 · 4092615
1 parent 213d205
commit 4092615
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 0 deletions.
diff --git a/keda/templates/manager/deployment.yaml b/keda/templates/manager/deployment.yaml
@@ -45,6 +45,7 @@ spec:
         {{- end }}
       {{- end }}
     spec:
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if .Values.priorityClassName }}
       priorityClassName: {{ .Values.priorityClassName | quote }}
       {{- end }}

diff --git a/keda/templates/metrics-server/deployment.yaml b/keda/templates/metrics-server/deployment.yaml
@@ -44,6 +44,7 @@ spec:
         {{- end }}
       {{- end }}
     spec:
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if .Values.priorityClassName }}
       priorityClassName: {{ .Values.priorityClassName | quote }}
       {{- end }}

diff --git a/keda/templates/webhooks/deployment.yaml b/keda/templates/webhooks/deployment.yaml
@@ -43,6 +43,7 @@ spec:
         {{- end }}
       {{- end }}
     spec:
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if .Values.priorityClassName }}
       priorityClassName: {{ .Values.priorityClassName | quote }}
       {{- end }}

diff --git a/keda/values.yaml b/keda/values.yaml
@@ -863,3 +863,7 @@ asciiArt: true
 
 # -- When specified, each rendered resource will have `app.kubernetes.io/managed-by: ${this}` label on it. Useful, when using only helm template with some other solution.
 customManagedBy: ""
+
+# -- Enable service links in pods. Although enabled, mirroring k8s default, it is highly recommended to disable,
+# due to its legacy status [Legacy container links](https://docs.docker.com/engine/network/links/)
+enableServiceLinks: true