fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA

[VietND96]

Provide a description of what has been changed

As KEDA exposes a metric to the HPA Controller, KEDA has to expose the raw value of the queue including all the jobs in-progress and pending, because it's the HPA controller the one which will calculate the right value based on the metric type (Value or AverageValue).

Selenium Grid scaler exposes the the sum of the in-progress sessions plus the pending sessions (after counting nodeMaxSessions to KEDA.

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes SeleniumHQ/docker-selenium#2464

Relates to #6331

[rickbrouwer]

I see you are using optional with a default value. I think if something has a default, optional does not need to be passed along. What do you think?

[VietND96]

I am not aware on this. So, we can remove optional from all trigger params which has default value already?
If yes, I will proceed the clean up

[rickbrouwer]

I am not aware on this. So, we can remove optional from all trigger params which has default value already? If yes, I will proceed the clean up

Yes, because if it doesn't exist the value is set with the default.
Reference:

keda/pkg/scalers/scalersconfig/typed_config.go

Lines 198 to 201 in 29400ed

	if !exists && params.Default != "" {
	exists = true
	valFromConfig = params.Default
	}

[VietND96]

Thanks! I updated the same.

[JorTurFer]

Thanks a lot for this awesome fix! ❤️

[JorTurFer]

/run-e2e selenium
Update: You can check the progress here

[JorTurFer]

/run-e2e selenium
Update: You can check the progress here