-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use toolchain
to define desired Go version
#6378
Conversation
I ran |
/run-e2e internal |
I see the benefits of not limiting the minimum version but only suggesting it in case of 3rd parties using KEDA as dependency, but we also must ensure that the user version to build and ship KEDA is the desired one and (AFAIK), Our current approach is based on generating updated build tools image so the |
I think so, both
it's possible those are not related to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
should we add a changelog entry? I think it's not necessary.
Follow-up from: kedacore#6305 (comment) Ref: https://go.dev/doc/modules/gomod-ref#go Use toolchain to define the desired Go compiler version to be used. Use `go` directive to show the minimum version it can still compile with. Signed-off-by: Matthias Diester <[email protected]>
69bbbd4
to
8bf524d
Compare
/run-e2e internal |
Follow-up from: #6305 (comment)
Ref: https://go.dev/doc/modules/gomod-ref#go
Use toolchain to define the desired Go compiler version to be used.
Use
go
directive to show the minimum version it can still compile with.Checklist
Relates to #6305