Skip to content

Commit

Permalink
Removed rfc-18 branch filter for CircleCI job execution
Browse files Browse the repository at this point in the history
Initally we added ignore filter for branches with rfc-18 prefix which
sounds like a good idea taking into account that we want to run GitHub
Actions for such branches, so duplication is not necessary. It turned
out that we require CircleCI job to be executed as a check before
merging to master. That's why we removed the filter and will execute the
job anywas. It shouldn't be much of a problem as the duplication will
take place only for workflows on rfc-18 branches as we filter them in
GiHub Actions configuration.
  • Loading branch information
nkuba committed Feb 15, 2021
1 parent b1612f1 commit 27d1d87
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ workflows:
branches:
ignore:
- master
- /rfc-18\/.*/
context: keep-dev
- build_token_dashboard_dapp:
filters:
Expand Down

0 comments on commit 27d1d87

Please sign in to comment.