Skip to content

Commit

Permalink
Merge pull request #2315 from keep-network/add-jq-to-osx-setup
Browse files Browse the repository at this point in the history
Add jq to the macos Setup Script

The manual setup doc details that "If you are not on macOS or you don’t have
Homebrew, you need to install:", and then lists jq, but the macos-setup.sh script
doesn't install jq for you.

I also confirmed that jq is indeed necessary for the project via bricking by not
having it XD

This PR adds a brew line to install it similar to how the rest of the dependencies are
installed!
  • Loading branch information
Shadowfiend authored Feb 2, 2021
2 parents b368dfc + e1d08f9 commit 2db0fb5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions scripts/macos-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ brew list pre-commit &>/dev/null || brew install pre-commit
go get -u golang.org/x/tools/cmd/goimports
go get -u golang.org/x/lint/golint

echo "Installing jq..."
brew list jq &>/dev/null || brew install jq

echo "Installing pre-commit and specified hooks..."
pre-commit install --install-hooks

Expand Down

0 comments on commit 2db0fb5

Please sign in to comment.