Skip to content

Commit

Permalink
Merge pull request #2329 from keep-network/actions-go-build-branch-fi…
Browse files Browse the repository at this point in the history
…lter

Run Go workflow only on `rfc-18/**` branches

We restricted branches for which Go build and test workflow gets
executed. Currently execution duplicates with workflow executed in CircleCI.

We defined rfc-18/ prefix. For branches with that prefix, jobs will be
executed in GH Actions instead of Circle CI.
  • Loading branch information
michalinacienciala authored Feb 12, 2021
2 parents 61f9bb7 + 45ae3a8 commit b3c24a7
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,9 @@ workflows:
- build_client_and_test_go:
filters:
branches:
ignore: master
ignore:
- master
- /rfc-18\/.*/
context: keep-dev
- build_token_dashboard_dapp:
filters:
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/client.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
name: Go

#TODO: extend the conditions once workflow gets tested together with other workflows
on:
#TODO: extend the conditions once workflow gets tested together with other workflows
on:
push:
branches:
- master
# TODO: Run on master after we're fully migrated from Circle CI
# - master
- "rfc-18/**"
pull_request:
branches:
# TODO: Run on all branches after we're fully migrated from Circle CI
- "rfc-18/**"
workflow_dispatch:

jobs:
Expand All @@ -21,7 +26,7 @@ jobs:
--target gobuild \
--tag go-build-env .
docker build \
--tag keep-client .
--tag keep-client .
- name: Create test results directory
run: |
mkdir test-results
Expand All @@ -37,6 +42,6 @@ jobs:
if: always() # guarantees that this action always runs, even if earlier steps fail
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
files: ./test-results/unit-tests.xml
files: ./test-results/unit-tests.xml
check_name: Go Test Results # name under which test results will be presented in GitHub (optional)
comment_on_pr: false # turns off commenting on Pull Requests

0 comments on commit b3c24a7

Please sign in to comment.