Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Go workflow only on rfc-18/** branches #2329

Merged
merged 1 commit into from
Feb 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,9 @@ workflows:
- build_client_and_test_go:
filters:
branches:
ignore: master
ignore:
- master
- /rfc-18\/.*/
context: keep-dev
- build_token_dashboard_dapp:
filters:
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/client.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
name: Go

#TODO: extend the conditions once workflow gets tested together with other workflows
on:
#TODO: extend the conditions once workflow gets tested together with other workflows
on:
push:
branches:
- master
# TODO: Run on master after we're fully migrated from Circle CI
# - master
- "rfc-18/**"
pull_request:
branches:
# TODO: Run on all branches after we're fully migrated from Circle CI
- "rfc-18/**"
workflow_dispatch:

jobs:
Expand All @@ -21,7 +26,7 @@ jobs:
--target gobuild \
--tag go-build-env .
docker build \
--tag keep-client .
--tag keep-client .
- name: Create test results directory
run: |
mkdir test-results
Expand All @@ -37,6 +42,6 @@ jobs:
if: always() # guarantees that this action always runs, even if earlier steps fail
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
files: ./test-results/unit-tests.xml
files: ./test-results/unit-tests.xml
check_name: Go Test Results # name under which test results will be presented in GitHub (optional)
comment_on_pr: false # turns off commenting on Pull Requests