Görli contracts deployment #387
Conversation
For the Relay we renamed the artifact name to BitcoinRelay as the previous one was ambiguous and could be confused with other contracts we use in dependency projects.
While deploying to Goerli with Alchemy we experienced some problems with transactions being rejected as the state of the chain wasn't reflecting the previously executed transaction. We added confirmation wait to let the Alchemy nodes propagate the transaction across their nodes.
We're not yet ready with the relay setup on goerli so we want to have a stub for now.
We expect some contraccts from other modules to be pre-deployed. Here we specify patsh where to find the artifacts.
We have USE_EXTERNAL_DEPLOY flag to explictly determine where we want to use the external deployment scripts.
This reverts commit 33ea4b3.
We add wait for running transactions on other networks than the hardhat
local network, e.g. development geth node or goreli.
There was a problem hiding this comment.
Generally, the changes look good to me. But there is some problem with the deployment on goerli - I'm getting:
initializing Bridge as ECDSA wallet owner
An unexpected error occurred:
Error: ERROR processing /home/runner/work/tbtc-v2/tbtc-v2/solidity/deploy/16_initialize_wallet_owner.ts:
TypeError: Cannot read property 'length' of undefined
This doesn't seem to be directly caused by the changes in this PR, it looks more like a problem with keep-network/keep-core#3061. @nkuba, do you think that merging of keep-network/keep-core#3096 may help?
Actually bfd629c shuould fix it. |
Yep, I no longer see that error. There's a different error now though, see my comment keep-network/coverage-pools#215 (comment). Usually such errors were caused by some problems with the config - when deployer account from dependencies did not match the one used currently for deploy. But it doesn't seem like it this time... Any ideas? [EDIT]: OK. I chatted with Kuba offline and he concluded that the error is related to the fact that for given |
There was a problem hiding this comment.
Deployment on goerli verified in job https://github.com/keep-network/tbtc-v2/runs/7744385930?check_suite_focus=true (workflow uses code combined from #387 and #382). Works as expected
Görli became a recommended test network after Ropsten's deprecation notice (link).
In this PR we update deployment scripts and configuration to support Görli.
The contracts were already deployed to Görli:
@keep-network/[email protected]