Retrieve wallet states concurrently in redemption service #828
+83
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n processing time
Shadowfiend
reviewed
Jan 31, 2025
| `Wallet is not in Live state ` + | ||
| // Using Promise.all, we retrieve all wallet states at once, | ||
| // significantly improving overall performance. | ||
| return Promise.all(bridgeWalletsByWalletPublicKeyHash).then(async (bridgeWallets) => { |
There was a problem hiding this comment.
The main issue with Promise.all is that one failure will fail the whole set. Do we have retries set up around this?
There was a problem hiding this comment.
(Of note: not morally opposed here and if we're feeling good about it I'm good with shipping it—it would require a full npm publish to include though, is that right?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
findWalletForRedemptionfunction to retrieve all wallet states concurrently by usingPromise.allrather than reading them one by one. This change reduces the redemption processing time from several minutes (6–7 minutes) down to approximately 15-20 seconds.Key Changes
Promise.all.Impact
Dramatically improved performance and user experience.
Significantly shortened wait times and reduced risk of timeouts.
Retrieve wallet states concurrently to significantly reduce redemptio…
Type of change
Notice