Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Janitorial Juice #19

Merged
merged 10 commits into from
Mar 21, 2019
Merged

Janitorial Juice #19

merged 10 commits into from
Mar 21, 2019

Conversation

mhluongo
Copy link
Member

@mhluongo mhluongo commented Mar 8, 2019

First pass at the custodial fee structure.

  • How much should people pay?
  • Custodial fee security deposits
  • Deposit ownership and maintenance of fees

@mhluongo mhluongo requested a review from Shadowfiend March 8, 2019 21:27
@Shadowfiend
Copy link
Contributor

Gimme dat JUICE

* "Earnest money"
* Deposit ownership
Signers put their own <<Bonding,funds at risk>> to assure depositors there will
be no foul play. The bonds they put down are capital that could otherwise be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notably, they also do work on behalf of the network.

0.75% lost to the costs of custody.

A decentralized model should allow a lower effective fee on custody by
introducing more competition to the space. There's a caveat, however- a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--, probsies. Can't even believe you're using hyphens instead of endashes. WHO ARE YOU ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredibly unfamiliar with adoc is who I am 😛

:custodial-fee: 20%
:base-custodial-time: 2 months
Once a deposit has been made and funded, the backing TBTC are minted. The
_custodial fee rate_ coupled with the _minimum custodial lockup period_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the minimum custodial lockup period?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incoming. Going to rework it but it's basically how you get the "custody fee security deposit"


Over time, the _custodial deposit_ is earned by signers, who will be paid for
their efforts when the `Deposit` is redeemed. Half of the unwithdrawn _minimum
custodial deposit_ must be maintained at all times for a `Deposit` to be
Copy link
Contributor

@Shadowfiend Shadowfiend Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this half set, or is it the parameter that decides the two undercollateralization thresholds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm setting it here, but there are reasons to make it a third parameter. Note this isn't quite the same issue as undercollateralization since it wouldn't be due to exchange rate fluctuations- the fee schedule is predictable

custodial deposit_ must be maintained at all times for a `Deposit` to be
considered maintained.

`Deposit` s that fall below this threshold will be put up for auction,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay now you're just throwing backticks around because you think they make the word deposit look cool 😝

In seriousness, may be worth cross-linking to the bonding subsection on undercollateralization? Or we may need to split the auction process into its own higher-level section that both reference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're just watching me too closely- this is like 20 edits from where it needs to be

... and yeah I'm trying to be consistent w my terrible backtick choice lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I AM WATCHING YOU ALWAYS

No sorry---I thought you wanted to roll this into an initial version to send to folks, so I tried to get you some thoughts before I bounced for the evening/weekend. My bad 🙊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I take it back- I want to keep this PR small ha. I opened #21 #22 and #23 to follow up on parameters, governance, and auctions.

@mhluongo mhluongo marked this pull request as ready for review March 12, 2019 19:00
@mhluongo
Copy link
Member Author

@Shadowfiend reduced the scope of this- ready for another look!

@mhluongo mhluongo requested a review from prestwich March 20, 2019 01:42
@mhluongo
Copy link
Member Author

Looking for a 👍 from one of you @prestwich 😀

custodial-fees/index.adoc Outdated Show resolved Hide resolved
custodial-fees/index.adoc Show resolved Hide resolved
deposits/index.adoc Outdated Show resolved Hide resolved
Be clear about what's collateral vs the actual pegged asset.
@mhluongo
Copy link
Member Author

Ready for another one look!

`1 / min(m, n)` in deposit security and
`1 / min(m, n) * OverCollateralizationFactor` in bonds, assuming for a moment
a shared value currency.
`1 / min(m, n)` in deposit security, or `1 / m` as `m` is strictly less than `n`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strictly less is not strictly true :P

other than that I think this is good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol that's embarrassing. Tempted to argue semantics around "threshold" vs "multisig" to save face but that wasn't even what I was trying to say

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tempted to argue" sounds like it could be the title of my autobiography

@prestwich
Copy link
Contributor

ACK

@mhluongo mhluongo merged commit 5edb544 into master Mar 21, 2019
@mhluongo mhluongo deleted the describing-custodial-fees branch March 21, 2019 01:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants