Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: speed up e2e: correct gitignore, cache playwright #2796

Merged
merged 6 commits into from
Dec 16, 2024
Merged

ci: speed up e2e: correct gitignore, cache playwright #2796

merged 6 commits into from
Dec 16, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Dec 10, 2024

Closes #2766

@Kiryous
chore: use node v20
50a033b 
(cherry picked from commit 642393f)
(cherry picked from commit b77090f)
@Kiryous
fix: add .gitignore to keep-ui for docker to respect it with context:…
f0fc659 
… ./keep-ui

(cherry picked from commit 5642f99)
(cherry picked from commit 828ccc5)
@Kiryous
cache playwrigth installation
bd63d66
@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 3:33pm

@Kiryous Kiryous changed the title Ci/2766 really simple faster ee ci: speed up e2e: correct gitignore, cache playwright Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.06%. Comparing base (aa11b5d) to head (ebc8e1a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2796       +/-   ##
===========================================
- Coverage   44.05%   31.06%   -13.00%     
===========================================
  Files         158       67       -91     
  Lines       15076     7417     -7659     
===========================================
- Hits         6642     2304     -4338     
+ Misses       8434     5113     -3321

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kiryous Kiryous marked this pull request as ready for review December 16, 2024 08:32
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 16, 2024
@dosubot dosubot bot added the Infrastructure Infrastructure related issues label Dec 16, 2024
@Kiryous Kiryous requested a review from shahargl December 16, 2024 16:13
talboren
talboren approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kiryous Kiryous merged commit 7da7018 into main Dec 16, 2024
12 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 16, 2024
@Kiryous Kiryous deleted the ci/2766-really-simple-faster-ee branch December 16, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

@VladimirFilonov VladimirFilonov VladimirFilonov approved these changes

@shahargl shahargl Awaiting requested review from shahargl

Assignees
No one assigned
Labels
Infrastructure Infrastructure related issues lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[👨🏻‍💻 Internal]: Make e2e tests run faster
3 participants
@Kiryous @VladimirFilonov @talboren