remove duplicate workflow installation and deletion

Makefile

@@ -27,7 +27,20 @@ all: test manager addonctl
 
 # Run tests
 test: generate fmt vet manifests
-	go test ./api/... ./controllers/... ./pkg/... ./cmd/... -coverprofile cover.out
+	go test ./api/... ./controllers/... ./pkg/... ./cmd/... -v -coverprofile cover.out
+
+# tests both controllers and api
+.PHONY: test.controllers
+test.controllers:
+	go test -v -race ./controllers/... -coverprofile cover.out
+
+.PHONY: test.pkg
+test.pkg:
+	go test -v -race ./pkg/... -coverprofile cover.out
+
+.PHONY: test.cmd
+test.cmd:
+	go test -v -race ./cmd/... -coverprofile cover.out
 
 # Run E2E tests
 bdd: fmt vet deploy
@@ -95,9 +108,22 @@ vet:
 	go vet ./...
 
 # Generate code
-generate: controller-gen
+generate: controller-gen types
 	$(CONTROLLER_GEN) object:headerFile=./hack/boilerplate.go.txt paths=./api/...
 
+# generates many other files (listers, informers, client etc).
+api/addon/v1alpha1/zz_generated.deepcopy.go: $(TYPES)
+	ln -s . v1
+	$(CODE_GENERATOR_GEN)/generate-groups.sh \
+			"deepcopy,client,informer,lister" \
+			github.com/keikoproj/addon-manager/pkg/client github.com/keikoproj/addon-manager/api\
+            addon:v1alpha1 \
+            --go-header-file ./hack/custom-boilerplate.go.txt
+	rm -rf v1
+
+.PHONY: types
+types: api/addon/v1alpha1/zz_generated.deepcopy.go
+
 # Build the docker image
 docker-build: manager
 	docker build --build-arg COMMIT=${GIT_COMMIT} --build-arg DATE=${BUILD_DATE} -t ${IMG} .
@@ -130,3 +156,19 @@ CONTROLLER_GEN=$(GOBIN)/controller-gen
 else
 CONTROLLER_GEN=$(shell which controller-gen)
 endif
+
+code-generator:
+ifeq (, $(shell which code-generator))
+	@{ \
+	set -e ;\
+	CONTROLLER_GEN_TMP_DIR=$$(mktemp -d) ;\
+	cd $$CONTROLLER_GEN_TMP_DIR ;\
+	curl -L -o code-generator.zip https://github.com/kubernetes/code-generator/archive/refs/tags/v0.21.5.zip ;\
+	unzip code-generator.zip ;\
+	mv code-generator-0.21.5 $(GOPATH)/bin/ ;\
+	rm -rf code-generator.zip ;\
+	}
+CODE_GENERATOR_GEN=$(GOBIN)/code-generator-0.21.5
+else
+CODE_GENERATOR_GEN=$(shell which code-generator)
+endif

api/addon/register.go

@@ -0,0 +1,28 @@
+package addon
+
+import "time"
+
+// Addon constants
+const (
+	Group          string = "addonmgr.keikoproj.io"
+	Version        string = "v1alpha1"
+	APIVersion     string = Group + "/" + Version
+	AddonKind      string = "Addon"
+	AddonSingular  string = "addon"
+	AddonPlural    string = "addons"
+	AddonShortName string = "addon"
+	AddonFullName  string = AddonPlural + "." + Group
+
+	ManagedNameSpace string = "addon-manager-system"
+
+	AddonResyncPeriod = 20 * time.Minute
+
+	FinalizerName = "delete.addonmgr.keikoproj.io"
+
+	ResourceDefaultManageByLabel = "app.kubernetes.io/managed-by"
+	ResourceDefaultManageByValue = "addonmgr.keikoproj.io"
+	ResourceDefaultOwnLabel      = "app.kubernetes.io/name"
+	ResourceDefaultPartLabel     = "app.kubernetes.io/part-of"
+
+	TTL = time.Duration(3) * time.Hour // 1 hour
+)

api/v1alpha1/addon_types.go → api/addon/v1alpha1/addon_types.go

@@ -123,6 +123,8 @@ const (
 	CnabPkg PackageType = "cnab"
 	// CompositePkg is a package type representing a composite package structure, just yamls
 	CompositePkg PackageType = "composite"
+	// Error used to indicate system error
+	Error ApplicationAssemblyPhase = "error"
 )
 
 // CmdType represents a function that can be performed with arguments
@@ -292,6 +294,8 @@ type AddonStatus struct {
 // +kubebuilder:printcolumn:name="STATUS",type="string",JSONPath=".status.lifecycle.installed"
 // +kubebuilder:printcolumn:name="REASON",type="string",JSONPath=".status.reason"
 // +kubebuilder:printcolumn:name="AGE",type="date",JSONPath=".metadata.creationTimestamp"
+// +genclient
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 type Addon struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
@@ -301,18 +305,14 @@ type Addon struct {
 }
 
 // +kubebuilder:object:root=true
-
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 // AddonList contains a list of Addon
 type AddonList struct {
 	metav1.TypeMeta `json:",inline"`
 	metav1.ListMeta `json:"metadata,omitempty"`
 	Items           []Addon `json:"items"`
 }
 
-func init() {
-	SchemeBuilder.Register(&Addon{}, &AddonList{})
-}
-
 // GetPackageSpec returns the addon package details from addon spec
 func (a *Addon) GetPackageSpec() PackageSpec {
 	return PackageSpec{
@@ -383,3 +383,21 @@ func (a *Addon) CalculateChecksum() string {
 func (a *Addon) GetInstallStatus() ApplicationAssemblyPhase {
 	return a.Status.Lifecycle.Installed
 }
+
+func (p ApplicationAssemblyPhase) Succeeded() bool {
+	switch p {
+	case Succeeded:
+		return true
+	default:
+		return false
+	}
+}
+
+func (p ApplicationAssemblyPhase) Completed() bool {
+	switch p {
+	case Succeeded, Failed, Error:
+		return true
+	default:
+		return false
+	}
+}

api/addon/v1alpha1/doc.go

@@ -0,0 +1,3 @@
+// +k8s:deepcopy-gen=package
+// +groupName=addonmgr.keikoproj.io
+package v1alpha1