Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor bugs #334

Merged
merged 1 commit into from
Jun 1, 2022
Merged

fix minor bugs #334

merged 1 commit into from
Jun 1, 2022

Conversation

shreyas-badiger
Copy link
Collaborator

Signed-off-by: sbadiger <[email protected]>
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #334 (fabcf11) into master (b33f5ae) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   39.14%   39.22%   +0.08%     
==========================================
  Files           7        7              
  Lines         723      724       +1     
==========================================
+ Hits          283      284       +1     
  Misses        415      415              
  Partials       25       25              
Flag Coverage Δ
unittests 39.22% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/upgrade.go 45.91% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33f5ae...fabcf11. Read the comment docs.

@shreyas-badiger shreyas-badiger merged commit d6994b8 into keikoproj:master Jun 1, 2022
@shreyas-badiger shreyas-badiger mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants