Improve support for external editing #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terminal option had few issues, mainly with always passing the -e. It added needless complexity for the cases, when running gvim is enough. So let's just drop that option completely and instead expect user to correctly configure editor, for example using: /set plugins.var.python.edit.editor "gvim -f" /set plugins.var.python.edit.run_externally "true"
With the previous implementation, there was a limit of being able to edit only one message at one time (since the file name was hard-coded). This commit instead uses a tempfile package to generate unique file for each message, meaning you can edit multiple messages at the same time (arguably only useful with run_externally = true).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits improving support for external editing.