-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not ovewrite custom attributes e.g. {:rel="sponsored"} #54
Comments
Hi @evodify ..You're welcome and thank you for this suggestion. I will add this feature in a future release. Meanwhile, kindly note that you should be able to add your rel attributes using HTML such as |
Hi @xplosionmind 😄 I'm also looking forward to the next release 😄 I'll try to fit this in asap. |
Hello @keithmifsud, do you have any ETA? |
Hello, @keithmifsud, any news? |
HI @xplosionmind ...sorry.. no news 😞 Meanwhile, kindly note that you should be able to add your rel attributes using HTML such as Sponsor. The plugin will add to the existing rel and not overwrite it smile |
@keithmifsud That's not the case. My HTML link in source is along the lines of |
I now use https://github.com/twinsunllc/jekyll-link-attributes instead; works like a charm. |
Fixes #54: do not overwrite custom attributes
Great plugin! Thanks for creating it.
Please, add a setting to skip manually set attributes.
For example, sometimes I publish sponsored links written in markdown as:
[some text](https://www.sposnsor.com/){:rel="sponsored"}
jekyll-target-blank would remove
rel="sponsored"
and add the defaulttarget="_blank" rel="noopener"
. This is not a desirable behavior. It should betarget="_blank" rel="sponsored noopener"
instead.Sorry, I do not know how to develop a jekyll plugin, so I cannot PR this feature.
The text was updated successfully, but these errors were encountered: