Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #54: do not overwrite custom attributes #67

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Fixes #54: do not overwrite custom attributes #67

merged 2 commits into from
Apr 18, 2023

Conversation

prplecake
Copy link
Contributor

Keeps the existing rel attributes if they exist. Fixes #54

@prplecake prplecake mentioned this pull request Apr 17, 2023
Closed
@keithmifsud keithmifsud merged commit 20711c1 into keithmifsud:master Apr 18, 2023
@keithmifsud
Copy link
Owner

Thanks a lot @prplecake 😄

@theyosh
Copy link

theyosh commented Apr 24, 2023

Can you provide a new version at https://rubygems.org/gems/jekyll-target-blank?

Thanks

@prplecake prplecake deleted the save-rel-attr branch April 24, 2023 20:29
@keithmifsud
Copy link
Owner

keithmifsud commented Apr 25, 2023 •
edited
Loading

Thanks @theyosh v2.0.2 is now available Gem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do not ovewrite custom attributes e.g. {:rel="sponsored"}
3 participants
@prplecake @keithmifsud @theyosh