Compat with newer Psych: Use safe_load with permitted_classes Poll and TimePollHead #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d TimePollHead Fixes kellerben#145, fixes kellerben#151 Based on the discussion in kellerben#145, @dl8dtl's initial patch suggestion and reading https://docs.ruby-lang.org/en/master/Psych.html to understand the remaining open question by @JoJoDeveloping where the config needs to go.
|
I independently figured this out before finding this PR and needed a few more classes to get things working, not sure why the discrepancy: dfe3f10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145, fixes #151
Based on the discussion in #145, @dl8dtl's initial patch suggestion and reading https://docs.ruby-lang.org/en/master/Psych.html to understand the remaining open question by @JoJoDeveloping where the config needs to go.