Skip to content

Commit

Permalink
Fix callback for github pages
Browse files Browse the repository at this point in the history
  • Loading branch information
kelseymorsebrown committed Oct 17, 2024
1 parent 0f41280 commit b6d8aaa
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
- closed
branches:
- 'main'
- 'gh-pages'
workflow_dispatch:
permissions:
contents: read
Expand All @@ -23,7 +24,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: npm
- name: Install dependencies
run: npm ci
Expand All @@ -39,7 +40,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: npm
- name: Install dependencies
run: npm ci
Expand All @@ -49,7 +50,7 @@ jobs:
REACT_APP_CLIENT_ID: ${{ secrets.API_CLIENT_ID }}
run: npx --no-install npm run build
- name: Upload artifact
uses: actions/upload-pages-artifact@v2
uses: actions/upload-pages-artifact@v3
with:
path: ./build
# Deployment job
Expand All @@ -62,4 +63,4 @@ jobs:
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v3
uses: actions/deploy-pages@v4
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: npm
- name: Install dependencies
run: npm ci
Expand All @@ -35,7 +35,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: npm
- name: Install dependencies
run: npm ci
Expand All @@ -50,7 +50,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: npm
- name: Install dependencies
run: npm ci
Expand All @@ -60,6 +60,6 @@ jobs:
REACT_APP_CLIENT_ID: ${{ secrets.API_CLIENT_ID }}
run: npx --no-install npm run build
- name: Upload artifact
uses: actions/upload-pages-artifact@v2
uses: actions/upload-pages-artifact@v3
with:
path: ./build
4 changes: 2 additions & 2 deletions src/utils/consts.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const CLIENT_ID = process.env.REACT_APP_CLIENT_ID;
export const REDIRECT_URI =
process.env.NODE_ENV === 'production'
? 'https://kelseymorsebrown.github.io/jammming/callback'
: 'http://localhost:3000/callback';
? 'https://kelseymorsebrown.github.io/jammming'
: 'http://localhost:3000';

0 comments on commit b6d8aaa

Please sign in to comment.