Add support for Unicode links #8
Conversation
mukrop
commented
Sep 13, 2019
•
mukrop
commented
- In function 'external?', URI is now escaped before split.
- This adheres to the recommendation in the URI docs: https://www.rubydoc.info/stdlib/uri/URI.parse
- Using CGI.escape instead of URI.escape as the latter is marked obsolete.
- Resolves Error: URI must be ascii only keithmifsud/jekyll-target-blank#33
- I'm asking for pull request here, since the original repository does not seem to be maintained anymore.
* In function 'external?', URI is now escaped before split. * This adheres to the recommendation in the URI docs: https://www.rubydoc.info/stdlib/uri/URI.parse * Using CGI.escape instead of URI.escape as the latter is marked obsolete. * Resolves keithmifsud#33
|
Details described in #9. |
|
@mukrop Looks good. |
|
Unfortunately, no :-/. Feel free to close this pull request as it's probably not merge-quality. I just wanted to add what I found if it was helpful for others (even though I was unable to make a proper functional pull request). |
|
Hi @mukrop, can you kindly submit the PR to the original repo? I have some time this week to look into :) |
|
I'll resubmit the PR to the original repo. Closing this one. |
|
I'm sorry for your inconvenience but thank you for your cooperation. |
