Update sphere.js #11
Open
Update sphere.js #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into a problem trying to use sphere.js to display a pano with GPano tags created by exiftool. I found the problem was a conflict between the getAttr function (which expects GPano:FullPanoWidthPixels="3000") and the tags created by exiftool (which are the format <GPano:FullPanoWidthPixels>3000</GPano:FullPanoWidthPixels>.
Added optional vertical field of view parameter (default 75) to function Photosphere.
Corrected getAttr to return value instead of array. Changed direction of auto-rotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem trying to use sphere.js to display a pano with GPano tags created by exiftool. I found the problem was a conflict between the getAttr function (which expects GPano:FullPanoWidthPixels="3000") and the tags created by exiftool (which are the format < GPano:FullPanoWidthPixels >3000< /GPano:FullPanoWidthPixels >.