-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sketchtags #38
base: master
Are you sure you want to change the base?
Sketchtags #38
Conversation
…position bug needs to be fixed
This looks good to me overall. A few things I'd comment is:
Also, leave a comment here, or update your pull request description, when the todo list is complete, if it isn't already. :) |
@Kronopath Thanks for your thoughts. The union of sets makes most sense now, so maybe one tag per sketch should be enforced after all? Also, any thoughts on the reset functionality? I'm still not sure how it should be represented. |
I'm not really sure I have much of a better idea of how to implement reset right now. Having it as a button like the tag buttongs (maybe with some slight visual differentiation) makes some sense. |
Note, Please do not merge before To-Do list completed, thoughts appreciated
Changes
this.tag = "tagName"
orthis.tags = ["tagName1", ... "tagNameN"]
properties to assign a tag (or a few).To-Do
Hard-to-see but visible enough GIF demo