Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketchtags #38

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Sketchtags #38

wants to merge 15 commits into from

Conversation

KTRosenberg
Copy link
Collaborator

Note, Please do not merge before To-Do list completed, thoughts appreciated

Changes

  • In a sketch file, add this.tag = "tagName" or this.tags = ["tagName1", ... "tagNameN"]properties to assign a tag (or a few).
  • In the sketch glyph chart, hover over a tag name (in the right-side list on the screen) to highlight all sketches that have that tag. Click on a tag name to toggle on / off state. This way, multiple tags can be combined if you wish to highlight multiple categories of sketches. The number pad / stroke count mask can also be combined with tag selections.

To-Do

  • Assign at least one tag to categorizable sketches, note: tags are not required.
  • The "reset tags" button is too similar to the tag selection buttons. Reset functionality is useful, but the button needs to be replaced with something different. It also doesn't have to be a button. I will either temporarily disable the reset (exiting and re-entering the glyph chart auto-resets) or find an alternative UI element. I would appreciate thoughts on this.
  • Should multiple tags per sketch be allowed after all?
  • General code clean-up, likely put duplicated code in reusable functions if possible

Hard-to-see but visible enough GIF demo

sketchtags_mini_gif_dec_2017

@Kronopath
Copy link
Collaborator

This looks good to me overall. A few things I'd comment is:

  1. This could be a good first step towards any future plans you guys at the lab are thinking about for sketch organization. I know we've talked about the possibility of having multiple "sketch libraries" that you could selectively load, and this looks like it could be a first step towards that direction.
  2. When you click multiple sketch tags, e.g. physics and math, I see two possible behaviours: either highlight every sketch that has physics as well as every sketch that has math, or highlight only sketches that have both the physics and math tags. In other words, either the union of those two sets or the intersection of them.
    Which behaviour works best depends on what you intend the sketch tags to be: if you're looking for them to be closer to one tag per sketch, making them more like categories, then your current system (union of sets) is best. If, though, you intend to emphasize sketches' ability to have multiple tags, then it might be worth considering highlighting the intersection of those sets instead.

Also, leave a comment here, or update your pull request description, when the todo list is complete, if it isn't already. :)

@KTRosenberg
Copy link
Collaborator Author

@Kronopath Thanks for your thoughts. The union of sets makes most sense now, so maybe one tag per sketch should be enforced after all?

Also, any thoughts on the reset functionality? I'm still not sure how it should be represented.

@Kronopath
Copy link
Collaborator

I'm not really sure I have much of a better idea of how to implement reset right now. Having it as a button like the tag buttongs (maybe with some slight visual differentiation) makes some sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants