-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-hint rename_schema.py #847
Type-hint rename_schema.py #847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor typing nit, otherwise looks great!
This reverts commit 7579db6.
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
=========================================
Coverage ? 94.76%
=========================================
Files ? 108
Lines ? 8398
Branches ? 0
=========================================
Hits ? 7958
Misses ? 440
Partials ? 0
Continue to review full report at Codecov.
|
@@ -186,36 +230,35 @@ class RenameSchemaTypesVisitor(Visitor): | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we specifically need this to be a class attribute here? If not, can we move it to module-level and make it sit right adjacent to the Union
definition that it duplicates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's specifically used for RenameSchemaTypesVisitor
, as it explicitly leaves out renaming the schema query type (i.e. SchemaQuery
). RenameQueryTypeFieldsVisitor
is the visitor that modifies the schema query type. Moving this class attribute to module-level could be confusing considering that we do actually modify the schema query type, just not in this particular class.
Co-authored-by: Predrag Gruevski <[email protected]>
Co-authored-by: Predrag Gruevski <[email protected]>
Step 1 as outlined in PR 834