Join recursive cte to base #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2020 13:08
added 3 commits
July 15, 2020 15:03
bojanserafimov
commented
Jul 15, 2020
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 94.75% 94.83% +0.07%
==========================================
Files 108 108
Lines 8432 8580 +148
==========================================
+ Hits 7990 8137 +147
- Misses 442 443 +1
Continue to review full report at Codecov.
|
added 3 commits
July 15, 2020 15:47
obi1kenobi
reviewed
Jul 15, 2020
graphql_compiler/tests/integration_tests/test_backends_integration.py
Outdated
Show resolved
Hide resolved
graphql_compiler/tests/integration_tests/test_backends_integration.py
Outdated
Show resolved
Hide resolved
graphql_compiler/tests/integration_tests/test_backends_integration.py
Outdated
Show resolved
Hide resolved
graphql_compiler/tests/integration_tests/test_backends_integration.py
Outdated
Show resolved
Hide resolved
…tion.py Co-authored-by: Predrag Gruevski <[email protected]>
…tion.py Co-authored-by: Predrag Gruevski <[email protected]>
…piler into cte_join
bojanserafimov
commented
Jul 16, 2020
| @@ -743,7 +743,7 @@ def __init__(self, sql_schema_info: SQLAlchemySchemaInfo, ir: IrAndMetadata): | |||
| self._relocate(ir.query_metadata_table.root_location) | |||
|
|
|||
| # Mapping aliases to the column used to join into them. | |||
| self._came_from: Dict[Alias, Column] = {} | |||
| self._came_from: Dict[Union[Alias, ColumnRouter], Column] = {} | |||
There was a problem hiding this comment.
The mention of aliases in the docstring is outdated. So is the entire _aliases field, since it doesn't only contain aliases anymore. I'm working on fixing this in the next PR, and I created an issue #882
obi1kenobi
reviewed
Jul 16, 2020
Co-authored-by: Predrag Gruevski <[email protected]>
obi1kenobi
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we generate queries that have the following from clause
FROM anon_1, anon_2, whereanon_1is the query before a recurse, andanon_2is the recursive CTE. Since the two ctes are not joined, if outputs are selected from each, the result will be a cartesian product, which is incorrect.There's two possible solutions:
a) Never select outputs from
anon_1, since the same values can be accessed fromanon_2b) Join the ctes in the
FROMclauseI went with option (b) since it makes it possible to implement recursion inside optional scope.
Note: When no outputs are selected from
anon_1, there's no need to join, sinceanon_1can be excluded from theFROMclause completely. This optimization can be implemented later, and I'm not sure if it makes a difference in runtime.Changes in this PR:
@optionalsemantics if the@recurseis in optional scopeThis PR fixes #866