Make modifier keys configurable, autodetect keyboard layout #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code only grabs Control, Alt, Control+Shift and Alt+Shift. While he lack of versatility is slightly upsetting, the real problem is that NumLock is considered a modifier so turning it on breaks the grabbing, confusing some people. This, for example, is a likely victim: http://askubuntu.com/questions/143573 This commit allows the user to specify the modifiers they want to grab when the program is invoked. This fix only applies to the unix binary! I also moved the in-code header documentation to a README since it was getting a little long.
There was a bogus accent getting in the way of Alt+Shift working. Also updated a comment referring to -DXDQ_GREEDY, a compilation flag that was obsoleted in the previous commit.
The Unix binary now automatically realizes whether the current layout is Dvorak and grabs/ungrabs keys as appropriate. This prevents the binary from shuffling the shortcuts all over the place when the user reverts to Qwerty, for example. This is part of kentonv#2. (It's missing the Windows implementation) The code also validates argvs better. It now complains if the user sends unknown modifiers as program arguments. These bogus strings used to be simply ignored.
I forgot that macros meant to be editable during compilation are supposed to have "XDQ_" as prefix. Fixed for XDQ_MODIFIER_LIMIT.
|
Hi there! This looks useful. Unfortunately I don't have time to review this carefully or really do any maintenance work on this code. :( As an alternative, I'd be happy to accept a change to the README which adds a link to your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2, #4 and also a more versatile solution than the proposed #5. However, it only applies to the Unix code; I left the Windows version unmodified.