Full CRUD for resource records #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tives" This reverts commit 1b013e0.
|
Still have yet to do anything regarding getting the gh workflow to complete successfully, currently working on optimizations. |
|
Wow, thanks for the work! I'll certainly merge whatever you come up with if it has some tests. |
Optimize the hell out of this by shuffling things into instance variables and only truly getting once
…tes" This reverts commit 100461f.
Add 'ptrhold' parameter for finer control over automatic PTR generation
Revert "Add 'ptrhold' parameter for finer control over automatic PTR generation"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of current main, I've added resource record management to the simple provider that was in place.
Admittedly, I don't have the appropriate development environment configured (i.e. linting) or tests created and it's not pretty so I don't expect this to make it into main any time soon, but this will hopefully get you a lot closer to having this feature ready should you be interested in working on it in the future. Thus far it seems to be fully functional CRUD, so I'll be using the fork in production in the meantime.