BatchRenormalization / ROR Removal #421
Conversation
|
@gabrieldemarmiesse As per comments in #415 |
|
@gabrieldemarmiesse Tests passing finally. |
| 'get_variable_shape', | ||
| 'Constraint' | ||
| } | ||
|
|
There was a problem hiding this comment.
It seems that the diff is big because you are changing an invisible character. Are you modifying the lines endings by any chance?
There was a problem hiding this comment.
Odd. Let me see what's going on here.
There was a problem hiding this comment.
Hmm PyCharm cant seem to fix it. I set it to use Unix line endings and redid the commit, but it seems it isnt being corrected.
There was a problem hiding this comment.
weird, my pycharm doesn't do this. Are you on windows?
There was a problem hiding this comment.
Yes im on Windows. That might be the cause.
Edit: Tried to fix it with another commit using Unix line endings inside PyCharm, but it doesnt seem to make a difference for some reason. The other commits show no such issues.
There was a problem hiding this comment.
I'm on windows with WSL and my pycharm doesn't do that. Weird. If you have notepad++ it does a really good job at changing line endings, much better than pycharm for this. Can you try?
There was a problem hiding this comment.
No change. How odd. Never experienced such an issue prior to this any commit. Notepad ++ changed to Unix Line encodings as well, but git registers this as a full change for some reason.
|
Closed via #424 |
Remove BatchRenormalization, Residual-of-Residual Networks application and related tests