-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Swin model adds to kerashub #1981
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @divyashreepathihalli! I need some guidance on how to test this locally. Could you help me with the steps? |
@divyashreepathihalli can you run test again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Higher level feedback for a start.
- Remove all "aliases," that's a CV pattern we did not continue. All arch configurations are stored in json files we upload to Kaggle/HF. The "aliases" is just the preset name you want to use.
- Follow the task setup we have in KerasHub. I am guessing for this model we want to add a
VideoClassifier
task that we can model heavily onImageClassifier
. - Remove all instances of
keras_cv
whereever they are. - Remove the presets stuff until presets are actually upload.
This will need a much more substantial rewrite to match the abstractions of KerasHub, rather than a more direct copy.
Thank you for the feedback. I will remove the aliases and replace them with the appropriate configurations stored in JSON files for Kaggle/HF. I'll follow the KerasHub task setup and create the VideoClassifier task based on the ImageClassifier model. |
#1755
@divyashreepathihalli