-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keras 3 example for "Transformer model for MIDI music generation" #1992
Add Keras 3 example for "Transformer model for MIDI music generation" #1992
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks great!
- Did you it works with all backends?
- Which backend is the fastest on the Colab GPU?
- Excluding text, how many lines of code do you end up with (are you able to run the rendering script)? You can use
scripts/tutobooks.py:count_locs_in_file
to count
- Update import statement for keras_hub - Fix documentation for audio dependencies - Remove unnecessary markdown annotation Other changes: - Update last modified date in MIDI generation example - Fix: Increase training epochs from 1 to 20 in MIDI generation example - Fix: use flip for unsupported negative step in torch - Fix: Remove unused learning rate
3cdad2f
to
1ccf450
Compare
1ccf450
to
e35c507
Compare
@fchollet Regarding your other questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome -- thanks a lot for the contribution!
Hi,
This is my first contribution, so apologies in advance for mistakes made!
I saw a call for contribution with an example of midi generation using transformers. I adapted the referenced code to keras 3.
Here are some notes on the implementation:
CachedMultiHeadAttention
to compact code, but probably getting worse results.keras_hub
?Thanks!