Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random seed doc #20575

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Random seed doc #20575

merged 10 commits into from
Dec 2, 2024

Conversation

roebel
Copy link
Contributor

@roebel roebel commented Dec 1, 2024

Following the discussion under #20569 this pull request contains a reformulation of the outdated doc concerning
the seed argument of all RNG functions. I also added a clarification to the SeedGenerator class documentation.

Resolves #20569

roebel and others added 4 commits December 1, 2024 19:51
Clarify the facts that 

- a global SeedGenerator is used by all random number generating functions in keras,
- a SeedGenerator is required for jit compilation with the JAX backend.
Copy link

google-cla bot commented Dec 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (dbf9878) to head (47d3188).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20575   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files         515      515           
  Lines       48257    48257           
  Branches     7541     7541           
=======================================
  Hits        39744    39744           
  Misses       6694     6694           
  Partials     1819     1819           
Flag Coverage Δ
keras 82.20% <ø> (ø)
keras-jax 65.25% <ø> (ø)
keras-numpy 60.23% <ø> (ø)
keras-tensorflow 66.24% <ø> (ø)
keras-torch 65.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 2, 2024
@fchollet fchollet merged commit bcdb8e4 into keras-team:master Dec 2, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Potential error in documentation of keras.random.uniform.
4 participants